pwman: Check-in [378769ec43]

Home Timeline Branches Tags Tickets Wiki

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Overview

Comment:	Extend the "don't overwrite fields if only carriage return is entered" to password field And also use malloc. What I'd done before wasn't doing what I thought. C newbie and all that. It must have picked up whatever `input` was initialised at, which must be one of STRING_SHORT, STRING_MEDIUM, etc. So it was just by luck it was working. It could have ended up truncating strings I guess? I'm in two minds about the benefit of dynamic allocation though. Since this is hardly a big memory hungry application I could probably just set `oldinput` to the largest possible string length and it'd be fine.
Downloads:	Tarball \| ZIP archive
Timelines:	family \| ancestors \| descendants \| both \| origin/tweaks \| trunk
Files:	files \| file ages \| folders
SHA3-256:	378769ec4367269d3ca376640adf89657d04b935313bcfbb3ad0dd88b69ff507
User & Date:	atomicules@lavabit.com 2013-03-23 21:27:08.000

Context

2014-01-03
22:31		Merge branch 'modernise' into tweaks check-in: 229ff25e0f user: base@atomicules.co.uk tags: origin/tweaks, trunk
22:25		WIP on tweaks: 98593a8 Extend the "don't overwrite fields if only carriage return is entered" to password field Leaf check-in: 4a8cb3e9a0 user: base@atomicules.co.uk tags: refs/stash, trunk
22:25		index on tweaks: 98593a8 Extend the "don't overwrite fields if only carriage return is entered" to password field check-in: db8bd43770 user: base@atomicules.co.uk tags: refs/stash, trunk
2013-03-23
21:27		Extend the "don't overwrite fields if only carriage return is entered" to password field And also use malloc. What I'd done before wasn't doing what I thought. C newbie and all that. It must have picked up whatever `input` was initialised at, which must be one of STRING_SHORT, STRING_MEDIUM, etc. So it was just by luck it was working. It could have ended up truncating strings I guess? I'm in two minds about the benefit of dynamic allocation though. Since this is hardly a big memory hungry application I could probably just set `oldinput` to the largest possible string length and it'd be fine. check-in: 378769ec43 user: atomicules@lavabit.com tags: origin/tweaks, trunk
2013-03-22
17:02		Don't overwrite fields if only carriage return is entered In other words, prevent accidentally deleting fields. This has always bugged me about PWman. If I edit an entry and accidentally press a number to edit one of the fields there is no way to escape out of this. You have to re-type or paste in the old value. This small change means that if you just enter return then the old value is kept. This is good enough for me. There is one downside: if you really want to make a field blank the only way to do it is by entering a space and then return - but I can't think of anytime I've ever wanted to do that. check-in: 1559d3c956 user: atomicules@lavabit.com tags: origin/tweaks, trunk

Changes

Changes to src/ui.c.